-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header titles added #2042
Header titles added #2042
Conversation
Your Render PR Server URL is https://chainsafe-components-stage-pr-2042.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8ubqbf9re0k9ejbt5og. |
Your Render PR Server URL is https://storage-ui-stage-pr-2042.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8ubqcf9re0k9ejbt670. |
Your Render PR Server URL is https://files-ui-stage-pr-2042.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c8ubqdf9re0k9ejbt6kg. |
There wasn't too much for me to test here but I did run through the pages listed on the issue on both desktop / mobile and everything visually looked as expected :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing translation for the title, I just commented for some of them, but we'd need them for all.
packages/files-ui/src/Components/Modules/FileBrowsers/SharedFileBrowser.tsx
Outdated
Show resolved
Hide resolved
…leBrowser.tsx Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Co-authored-by: Thibaut Sardan <33178835+Tbaut@users.noreply.github.com>
Thanks for that, Added the translation tags, I left out "Chainsafe Files" part for translations as we've kept it that way everywhere else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good but when I logged into Files, on the render preview, I got an error:
Helmet expects a string as a child of <title>. Did you forget to wrap your children in braces? ( <title>{``}</title> ) Refer to our API for more information.
I guess the Trans wasn't expected there. so we probably need {${t
title} - Chainsafe Files
} or something along this line
Thanks for saving this one, updates are in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested Files and it looks good.
closes #1611
Submission checklist:
No UI changes